🐛(backend) set installment error in debit pending installment #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the payment provider has issues, we were supposed to pass the installment id to the the method `set_installment_error` instead of the installment object. This created issues in our sentry, and we coudn't follow the fact that payment provider raised an exception when calling `create_zero_click_payment`.
jonathanreveille
deleted the
hotfix/set_installment_error_fix_when_payment_provider_has_issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When the payment provider has issues, we were supposed to pass the installment id to the the method
set_installment_errorinstead of the installment object. This created issues in our sentry, and we couldn't follow the fact that payment provider raised an exception when callingcreate_zero_click_payment.That behavior led us to believe that nothing happened, but in fact there was an issue with the payment provider while attempting to call the method to debit an installment.
Proposal
set_installment_error