Skip to content

Add support for SAM 2 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giswqs opened this issue Jul 30, 2024 · 10 comments · Fixed by #312
Closed

Add support for SAM 2 #300

giswqs opened this issue Jul 30, 2024 · 10 comments · Fixed by #312
Labels
Feature request New feature or request

Comments

@giswqs
Copy link
Member

giswqs commented Jul 30, 2024

https://github.com/facebookresearch/segment-anything-2

https://github.com/lujiazho/SegDrawer

@amjadraza
Copy link

Looking forward to it.

@lionelhorn
Copy link

I was about to ask if this repo would gain anything to add SAM2. And here I see you already made an issue :)

Would segment-geospatial benefit from SAM2 new capabilities?

@giswqs
Copy link
Member Author

giswqs commented Jul 31, 2024

SAM 2 has installation issues at the moment. I am going to wait for Hugging Face transformers to add support for SAM 2. That will make it easier to integrate SAM 2 into SAMGeo.
huggingface/transformers#32308

@SFrav
Copy link

SFrav commented Aug 6, 2024

Would predicting on a timeseries with SAM2 improve the accuracy of any individual frame when compared to a single image?

@skylning
Copy link

skylning commented Aug 7, 2024

Looking forward to it.

@giswqs
Copy link
Member Author

giswqs commented Aug 13, 2024

Waiting for PR to be merged. Then we can add support for SAM 2.
huggingface/transformers#32394

@giswqs
Copy link
Member Author

giswqs commented Sep 9, 2024

I have added sam2 to conda-forge. Will be working on integrating sam2 into samgeo.
https://anaconda.org/conda-forge/sam2

@jamescrowley
Copy link

@giswqs if there are ways to support the effort integrating sam2, I'd be happy to help

@giswqs
Copy link
Member Author

giswqs commented Sep 12, 2024

@jamescrowley Awesome! I plan to start working on it tomorrow. Hope to submit the PR soon. Feedback, suggestions, and contributions are very welcome.

@giswqs giswqs added the Feature request New feature or request label Sep 14, 2024
@giswqs giswqs linked a pull request Sep 14, 2024 that will close this issue
@jamescrowley
Copy link

Awesome, thanks @giswqs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants