shellcheck changes and add to CI

Signed-off-by: Orion Poplawski <orion@nwra.com>

Author: opoplawski

components/compiler-families/intel-compilers-devel/SOURCES/ohpc-update-modules-intel

@@ -2,7 +2,7 @@
 # Do not overwrite existing files
 # Write the new file as rpmnew
 testfile () {
-    if [ -e $1 ]; then
+    if [ -e "$1" ]; then
        echo "$1.rpmnew"
     else
        echo "$1"
@@ -18,7 +18,7 @@ modprocess () {
             return
         fi
     fi
-    md5sum ${modname} >> @@oneapi_manifest@@
+    md5sum "${modname}" >> @@oneapi_manifest@@
 }
 
 rm -f @@oneapi_manifest@@
@@ -34,8 +34,8 @@ fi
 # Set system defaults for default OBS oneAPI modules
 for tool in @@exact_deps@@; do
   filename=@@OHPC_MODULEDEPS@@/oneapi/${tool%%/*}/.version
-  echo "#%Module1.0" > ${filename}
-  echo "set  ModulesVersion  \"${tool##*/}\"" >> ${filename}
+  echo "#%Module1.0" > "${filename}"
+  echo "set  ModulesVersion  \"${tool##*/}\"" >> "${filename}"
 done
 
 # Create an OpenHPC module file for each version found in compilers
@@ -56,9 +56,9 @@ for compilers in @@OHPC_MODULEDEPS@@/oneapi/compiler/2*; do
     echo "--> Installing modulefile for version=${ver}"
     # Do not overwrite existing files
     # Write the new file as rpmnew
-    modname=$(testfile @@OHPC_MODULES@@/intel/$ver)
+    modname=$(testfile @@OHPC_MODULES@@/intel/"$ver")
 
-    cat << EOF > ${modname}
+    cat << EOF > "${modname}"
 #%Module1.0#####################################################################
 
 set version "$ver"
@@ -95,12 +95,12 @@ module load "$mklver"
 family "compiler"
 EOF
 
-    modprocess ${modname}
+    modprocess "${modname}"
 
     # Provide standalone module for use with GNU toolchain
-    modname=$(testfile  @@OHPC_MODULEDEPS@@/gnu/mkl/$ver)
+    modname=$(testfile  @@OHPC_MODULEDEPS@@/gnu/mkl/"$ver")
 
-    cat << EOF > ${modname}
+    cat << EOF > "${modname}"
 #%Module1.0#####################################################################
 
 set version "$ver"
@@ -121,15 +121,15 @@ prepend-path  MODULEPATH       @@OHPC_MODULEDEPS@@/oneapi
 module load   "$mklver"
 EOF
 
-    modprocess ${modname}
+    modprocess "${modname}"
 done
 
 # Set default version to match that used to build OpenHPC packages
 modname=$(testfile @@OHPC_MODULES@@/intel/.version)
 
-cat << EOF > ${modname}
+cat << EOF > "${modname}"
 #%Module1.0#####################################################################
 set     ModulesVersion      "@@exact_intel_ver_module@@"
 EOF
 
-modprocess ${modname}
+modprocess "${modname}"

tests/ci/Makefile

@@ -35,6 +35,7 @@ whitespace-lint:
 	@echo "Checking spec files for trailing whitespaces"
 	cd ../../; ! git --no-pager grep -E '\s+$$' \*.spec \
 		components/admin/prun/SOURCES/prun \
+		components/compiler-families/intel-compilers-devel/SOURCES/ohpc-update-modules-intel \
 		components/rms/slurm/SOURCES/slurm.epilog.clean \
 		tests/user-env/mem_limits \
 		tests/user-env/ompi_info \
@@ -60,6 +61,7 @@ shellcheck-lint:
 		../../components/OHPC_setup_compiler \
 		../../components/OHPC_setup_mpi \
 		../../components/admin/prun/SOURCES/prun \
+		../../components/compiler-families/intel-compilers-devel/SOURCES/ohpc-update-modules-intel \
 		../../components/rms/slurm/SOURCES/slurm.epilog.clean \
 		../../tests/libs/netcdf/ohpc-tests/netcdf_all_test_mpi_families \
 		../../tests/libs/netcdf/ohpc-tests/test_mpi_families
@@ -91,4 +93,5 @@ shfmt-lint:
 		../../tests/libs/plasma/tests/test_module
 	shfmt -w -d \
 		../../tests/ci/prepare-ci-environment.sh \
+		../../components/compiler-families/intel-compilers-devel/SOURCES/ohpc-update-modules-intel \
 		../../components/rms/slurm/SOURCES/slurm.epilog.clean