Fix MANPATH override in modulefiles by preserving system manpath

[Amrithasuresh]

This PR resolves issue #2070 by prefixing a colon (:) to MANPATH.

This preserves system default man pages while still including software-specific manpaths. Without this, modules may override and hide manpages such as man bash, especially on Rocky Linux 9.

[adrianreber]

Thanks. Have you thought about handling this directly in lmod? Instead of changing every module file, maybe it would make sense to talk to the lmod maintainers if this could be done directly in lmod?

[github-actions]

Test Results

0 files   - 27  0 suites   - 27   0s ⏱️ -38s
0 tests  - 53  0 ✅  - 49  0 💤  - 4  0 ❌ ±0 
0 runs   - 99  0 ✅  - 93  0 💤  - 6  0 ❌ ±0 

Results for commit f39913b. ± Comparison against base commit 82a24c4.

[Amrithasuresh]

Thank you. Will reach out to the lmod.

[adrianreber]

@Amrithasuresh Looking at the comments in the lmod ticket it seems it could be fixed with a couple of lines in our scripts in /etc/profile.d. Do you want to open a PR to add the missing lines?

[Amrithasuresh]

@adrianreber Sure. Thanks.

Is it the change here? I will add a line here ohpc/components/admin/lmod/SPECS/lmod.spec

if [ \$EUID -eq 0 ]; then
    export MODULEPATH=%{OHPC_ADMIN}/modulefiles:%{OHPC_MODULES}
else
    export MODULEPATH=%{OHPC_MODULES}
fi

export MANPATH="\${MANPATH:-}:"

export BASH_ENV=%{OHPC_ADMIN}/lmod/lmod/init/bash

[adrianreber]

You should also handle it in the .csh script. I never used csh myself, so not sure how it would look there.

I am not 100% convinced that export MANPATH="\${MANPATH:-}:" is correct. If run multiple times it will add lot's of : to the MANPATH.

[Amrithasuresh]

Thank you for the comment. How about this change here ohpc/components/admin/lmod/SPECS/lmod.spec

bash shell block

if [ \$EUID -eq 0 ]; then
    export MODULEPATH=%{OHPC_ADMIN}/modulefiles:%{OHPC_MODULES}
else
    export MODULEPATH=%{OHPC_MODULES}
fi

if [ -n "\$MANPATH" ]; then
    export MANPATH="\$MANPATH:"
else
    export MANPATH=":"
fi

export BASH_ENV=%{OHPC_ADMIN}/lmod/lmod/init/bash

C shell block

if ( \`id -u\` == "0" ) then
   setenv MODULEPATH "%{OHPC_ADMIN}/modulefiles:%{OHPC_MODULES}"
else
   setenv MODULEPATH "%{OHPC_MODULES}"
endif

if ( $?MANPATH ) then
    setenv MANPATH "${MANPATH}:"
else
    setenv MANPATH=":"
endif

# Initialize modules system
source %{OHPC_ADMIN}/lmod/lmod/init/csh >/dev/null

[adrianreber]

Not sure if I understand the problem correctly, but looking at the lmod source code it seems to use slightly different code at:

• https://github.com/TACC/Lmod/blob/main/init/profile.in#L59
• https://github.com/TACC/Lmod/blob/main/init/cshrc.in#L63

Why are you doing it differently?

[Amrithasuresh]

I am still learning how to contribute to open source projects, and this is one of my first PRs to OpenHPC. I really appreciate your patience while I am getting familiar with the process. Please check. I will see whether the test is successful or not. If not I will modify accordingly.

Thank you for your time and support.

[adrianreber]

I am still learning how to contribute to open source projects, and this is one of my first PRs to OpenHPC. I really appreciate your patience while I am getting familiar with the process. Please check. I will see whether the test is successful or not. If not I will modify accordingly.

Thank you for your time and support.

Sure, no problem.

[adrianreber]

See #2105