Skip to content

8355230: Crash in fuzzer tests: assert(n != nullptr) failed: must not be null #25268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented May 16, 2025

During IGVN, TypeNode::make_paths_from_here_dead() follows data
nodes until a Phi. The Region input for the input that that logic
goes through to reach the Phi is null causing the crash. I propose
simply adding an extra check for that corner case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355230: Crash in fuzzer tests: assert(n != nullptr) failed: must not be null (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25268/head:pull/25268
$ git checkout pull/25268

Update a local copy of the PR:
$ git checkout pull/25268
$ git pull https://git.openjdk.org/jdk.git pull/25268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25268

View PR using the GUI difftool:
$ git pr show -t 25268

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25268.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant