Skip to content

8354078: Shenandoah: Make the generational mode be non-experimental (implementation) #25270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented May 16, 2025

Testing:

% ./build/linux-x86_64-server-fastdebug/jdk/bin/java -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational --version
openjdk 25 2025-09-16
OpenJDK Runtime Environment (fastdebug build 25-make-genshen-non-experimental)
OpenJDK 64-Bit Server VM (fastdebug build 25-make-genshen-non-experimental, mixed mode)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8354079 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8354078: Shenandoah: Make the generational mode be non-experimental (implementation) (Enhancement - P4)
  • JDK-8354079: Shenandoah: Make the generational mode be non-experimental (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25270/head:pull/25270
$ git checkout pull/25270

Update a local copy of the PR:
$ git checkout pull/25270
$ git pull https://git.openjdk.org/jdk.git pull/25270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25270

View PR using the GUI difftool:
$ git pr show -t 25270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25270.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break out the production bubbly! 🍾

Reviewed!

@ysramakrishna
Copy link
Member

Just noticed that gc/shenandoah/options/TestModeUnlock.java needs to be taught that "generational" is no longer experimental. It's failing in the GHA tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Pull request needs approved CSR before integration hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants