8357143: New test AOTCodeCompressedOopsTest.java fails on platforms without AOT Code Cache support

[vnkozlov]

New test missed check for AOT code caching supported platforms.

Instead of adding missed checks I added new jtreg's VM property vm.cds.supports.aot.code.caching to simplify checks in new AOT code caching tests.

Tested tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357143: New test AOTCodeCompressedOopsTest.java fails on platforms without AOT Code Cache support (Bug - P4)

Reviewers

• Ashutosh Mehra (@ashu-mehra - Committer)
• Fei Yang (@RealFYang - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25272/head:pull/25272
$ git checkout pull/25272

Update a local copy of the PR:
$ git checkout pull/25272
$ git pull https://git.openjdk.org/jdk.git pull/25272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25272

View PR using the GUI difftool:
$ git pr show -t 25272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25272.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357143: New test AOTCodeCompressedOopsTest.java fails on platforms without AOT Code Cache support

Reviewed-by: asmehra, fyang, shade, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• effe40a: 8351843: change test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to a manual test
• 2fb3329: 8356846: Remove unnecessary List.contains key from TIFFDirectory.removeTagSet
• 67fb1ee: 8356946: x86: Optimize interpreter profile updates
• ... and 11 more: https://git.openjdk.org/jdk/compare/46a12e781edcbe9da7bd39eb9e101fc680053cef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[vnkozlov]

@TheRealMDoerr please verify the fix.

[vnkozlov]

@ashu-mehra please review.

[mlbridge]

Webrevs

• 00: Full (59f0ee6e)

[ashu-mehra]

@vnkozlov thank you for fixing this. Looks fine to me.

[vnkozlov]

Thank you @ashu-mehra

[RealFYang]

LGTM. Same issue exists on linux-riscv64. The same test won't be selected on this platform after this change.

[TheRealMDoerr]

LGTM. Thanks for fixing it!

[vnkozlov]

Thank you all for reviews.

[vnkozlov]

/integrate

[openjdk]

Going to push as commit 6a58af3.
Since your change was applied there have been 25 commits pushed to the master branch:

• 84a98ab: 8357166: Many AOT tests failed with VM crash
• fbc12be: 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test
• 265d630: 8357187: JFR: User-defined defaults should be respected when an incorrect setting is set
• ... and 22 more: https://git.openjdk.org/jdk/compare/46a12e781edcbe9da7bd39eb9e101fc680053cef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit 6a58af3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.