Skip to content

8357062: Update Public Suffix List to 823beb1 #25273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented May 16, 2025

This is a routine update to synchronize with the Mozilla Public Suffix List for JDK 25, matching commit 823beb1 from 2025-05-12.

The test has been updated to reflect corresponding changes.

If you are really curious about whether I downloaded the correct file, please run:
diff <(curl https://raw.githubusercontent.com/openjdk/jdk/refs/pull/25273/head/src/java.base/share/data/publicsuffixlist/public_suffix_list.dat) <(curl https://raw.githubusercontent.com/publicsuffix/list/823beb1/public_suffix_list.dat)
You can see the PR number and the PSL commit ID inside the command.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357062: Update Public Suffix List to 823beb1 (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25273/head:pull/25273
$ git checkout pull/25273

Update a local copy of the PR:
$ git checkout pull/25273
$ git pull https://git.openjdk.org/jdk.git pull/25273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25273

View PR using the GUI difftool:
$ git pr show -t 25273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25273.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

@wangweij
Copy link
Contributor Author

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@wangweij
The core-libs label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant