Skip to content

JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java #25279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented May 17, 2025

CopyAreaOOB.java was failing intermittently on some platforms on CI but recently it started to fail more frequently on macos-aarch64 when the entire test suite runs.

Test failure is not reproducible when the test is run individually (multiple times) on CI.

Rewritten the test and added debug logs that will be helpful to figure out the issue.

  • Added code to capture screenshot (entire screen as well as the frame) in case of failure.
  • Since it tests multiple regions added a StringBuffer to consolidate the error logs before throwing RuntimeException.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357082: Stabilize and add debug logs to CopyAreaOOB.java (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25279/head:pull/25279
$ git checkout pull/25279

Update a local copy of the PR:
$ git checkout pull/25279
$ git pull https://git.openjdk.org/jdk.git pull/25279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25279

View PR using the GUI difftool:
$ git pr show -t 25279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25279.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2025
@openjdk
Copy link

openjdk bot commented May 17, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 17, 2025
@mlbridge
Copy link

mlbridge bot commented May 17, 2025

Webrevs

}

private static void createTestUI() {
frame = new Frame();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to call all these methods on the EDT, these are AWT components that should handle multithreaded usage (main/EDT/toolkit threads). It is possible that the issue is only reproducible on macOS due to synchronization problems related to the metal pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants