[PATCH] Remove unnecessary List.get before remove in PopupFactory #25283
+7
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of separate List.get+List.remove calls we can use single
removeFirst
. It's clearer.Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25283/head:pull/25283
$ git checkout pull/25283
Update a local copy of the PR:
$ git checkout pull/25283
$ git pull https://git.openjdk.org/jdk.git pull/25283/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25283
View PR using the GUI difftool:
$ git pr show -t 25283
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25283.diff