Skip to content

[PATCH] Remove unnecessary List.get before remove in PopupFactory #25283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented May 17, 2025

Instead of separate List.get+List.remove calls we can use single removeFirst. It's clearer.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25283/head:pull/25283
$ git checkout pull/25283

Update a local copy of the PR:
$ git checkout pull/25283
$ git pull https://git.openjdk.org/jdk.git pull/25283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25283

View PR using the GUI difftool:
$ git pr show -t 25283

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25283.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2025

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 17, 2025

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant