8355574: Fatal error in abort_verify_int_in_range due to Invalid CastII

[merykitty]

Hi,

The issue here is that the CastLLNode is created before the actual check that ensures the range of the input. This patch fixes it by moving the creation to the correct place, which is under inline_block. I also noticed that the code there seems incorrect and confusing. ArrayCopyNode::get_partial_inline_vector_lane_count takes the length of the array, not the size in bytes. If you look into the method it will multiply const_len with type2aelementbytes(bt) to get the size in bytes of the array. In the runtime test, we compare length << log2(type2bytes(bt)) with ArrayOperationPartialInlineSize. This seems confusing, why don't we just compare length with ArrayOperationPartialInlineSize / type2bytes(bt), it also unifies the test with the actual cast.

Please take a look and leave your reviews, thanks a lot.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355574: Fatal error in abort_verify_int_in_range due to Invalid CastII (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25284/head:pull/25284
$ git checkout pull/25284

Update a local copy of the PR:
$ git checkout pull/25284
$ git pull https://git.openjdk.org/jdk.git pull/25284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25284

View PR using the GUI difftool:
$ git pr show -t 25284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25284.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@merykitty The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (fdbb88bd)
• 02: Full - Incremental (72e72180)
• 01: Full - Incremental (336c295c)
• 00: Full (5f4487d8)