8278874: tighten VerifyStack constraints

[dean-long]

The VerifyStack logic in Deoptimization::unpack_frames() attempts to check the expression stack size of the interpreter frame against what GenerateOopMap computes. To do this, it needs to know if the state at the current bci represents the "before" state, meaning the bytecode will be reexecuted, or the "after" state, meaning we will advance to the next bytecode. The old code didn't know how to determine exactly what state we were in, so it checked both. This PR cleans that up, so we only have to compute the oopmap once. It also removes old SPARC support.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8278874: tighten VerifyStack constraints

Issue

• JDK-8278874: tighten VerifyStack constraints (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26121/head:pull/26121
$ git checkout pull/26121

Update a local copy of the PR:
$ git checkout pull/26121
$ git pull https://git.openjdk.org/jdk.git pull/26121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26121

View PR using the GUI difftool:
$ git pr show -t 26121

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26121.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dean-long The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (535fbb05)
• 05: Full - Incremental (1e46cce1)
• 04: Full - Incremental (54919be0)
• 03: Full - Incremental (c93ca9e1)
• 02: Full - Incremental (6042a475)
• 01: Full - Incremental (5b7d4bca)
• 00: Full (a2694ede)

[dean-long]

/label hotspot-compiler

[openjdk]

@dean-long
The hotspot-compiler label was successfully added.

[dean-long]

@eme64 and @mhaessig, this is somewhat a followup to 8336906, so you may be the best candidates to volunteer to look at this :-)

[mhaessig]

Thank you for this enhancement, @dean-long! I made a first pass to try and understand the logic, but ended up only commenting on cosmetics. I'll do a second pass next week.