-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8278874: tighten VerifyStack constraints #26121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dlong! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@dean-long The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/label hotspot-compiler |
@dean-long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this enhancement, @dean-long! I made a first pass to try and understand the logic, but ended up only commenting on cosmetics. I'll do a second pass next week.
Co-authored-by: Manuel Hässig <manuel@haessig.org>
Co-authored-by: Manuel Hässig <manuel@haessig.org>
Co-authored-by: Manuel Hässig <manuel@haessig.org>
The VerifyStack logic in Deoptimization::unpack_frames() attempts to check the expression stack size of the interpreter frame against what GenerateOopMap computes. To do this, it needs to know if the state at the current bci represents the "before" state, meaning the bytecode will be reexecuted, or the "after" state, meaning we will advance to the next bytecode. The old code didn't know how to determine exactly what state we were in, so it checked both. This PR cleans that up, so we only have to compute the oopmap once. It also removes old SPARC support.
Progress
Warning
8278874: tighten VerifyStack constraints
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26121/head:pull/26121
$ git checkout pull/26121
Update a local copy of the PR:
$ git checkout pull/26121
$ git pull https://git.openjdk.org/jdk.git pull/26121/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26121
View PR using the GUI difftool:
$ git pr show -t 26121
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26121.diff
Using Webrev
Link to Webrev Comment