8177650: JShell tool: packages in classpath don't appear in completions

[lahodaj]

JShell provides the code completion feature, where it suggests possible follow ups for a given snippet prefix. To allow completion for packages, JShell uses a background task to go through known classes and create an index for them.

There are two problems with this background task:

• the classpath is read from the JShell's FileManager, but the FileManager may not be configured with the compile options yet, so the classpath may not be filled yet,
• the module path is not included in the list of paths to paths to search

This PR proposes to:

• use FileManager configured by passing the compile options through javac
• include the module path in the search path

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8177650: JShell tool: packages in classpath don't appear in completions (Bug - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26137/head:pull/26137
$ git checkout pull/26137

Update a local copy of the PR:
$ git checkout pull/26137
$ git pull https://git.openjdk.org/jdk.git pull/26137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26137

View PR using the GUI difftool:
$ git pr show -t 26137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26137.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8177650: JShell tool: packages in classpath don't appear in completions

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 194 new commits pushed to the master branch:

• 1cde536: 8361868: [GCC static analyzer] complains about missing calloc - NULL checks in p11_util.c
• 1a6cbe4: 8361639: JFR: Incorrect top frame for I/O events
• 3fd89be: 8362284: RISC-V: cleanup NativeMovRegMem
• ... and 191 more: https://git.openjdk.org/jdk/compare/74822ce12acaf9816aa49b75ab5817ced3710776...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (54eed125)
• 00: Full (ec2dcb89)

[lahodaj]

/label remove kulla

[openjdk]

@lahodaj
The label kulla is not a valid label.
These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[asotona]

Looks good to me.