Skip to content

8361426: (ref) Remove jdk.internal.ref.Cleaner #26141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 5, 2025

Please review this change that removes the class jdk.internal.ref.Cleaner.
It is no longer used after JDK-8344332.

Testing: mach5 tier1-3


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8361426: (ref) Remove jdk.internal.ref.Cleaner (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26141/head:pull/26141
$ git checkout pull/26141

Update a local copy of the PR:
$ git checkout pull/26141
$ git pull https://git.openjdk.org/jdk.git pull/26141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26141

View PR using the GUI difftool:
$ git pr show -t 26141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26141.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2025

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2025

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361426: (ref) Remove jdk.internal.ref.Cleaner

Reviewed-by: jpai, vklang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2025
@openjdk
Copy link

openjdk bot commented Jul 5, 2025

@kimbarrett The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me and matches with what was discussed about this in a recent PR #25289 (comment).

It would be good to get another review for this before integrating.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025
@kimbarrett
Copy link
Author

@jaikiran requested another reviewer, so

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@kimbarrett
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 8, 2025
Copy link
Contributor

@viktorklang-ora viktorklang-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kim!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025
@kimbarrett
Copy link
Author

Thanks for reviews @jaikiran and @viktorklang-ora

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

Going to push as commit 117f0b4.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2025
@openjdk openjdk bot closed this Jul 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@kimbarrett Pushed as commit 117f0b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants