Skip to content

8361445: javac crashes on unresolvable constant in @SuppressWarnings #26142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 6, 2025

Consider this code:

@SuppressWarnings(CONST)
public class Ann {
    public static final String CONST = "";
}

javac will crash attempting to compile it:

$ javac -XDdev /tmp/Ann.java
/tmp/Ann.java:1: error: cannot find symbol
@SuppressWarnings(CONST)
                  ^
  symbol: variable CONST
1 error
An exception has occurred in the compiler (26-internal). Please file a bug against the Java compiler via the Java bug reporting page (https://bugreport.java.com/) after checking the Bug Database (https://bugs.java.com/) for duplicates. Include your program, the following diagnostic, and the parameters passed to the Java compiler in your report. Thank you.
java.lang.ClassCastException: class com.sun.tools.javac.code.Attribute$Error cannot be cast to class com.sun.tools.javac.code.Attribute$Constant (com.sun.tools.javac.code.Attribute$Error and com.sun.tools.javac.code.Attribute$Constant are in module jdk.compiler of loader 'app')
        at jdk.compiler/com.sun.tools.javac.code.Lint.suppressionsFrom(Lint.java:533)
...

The reason is that the unresolvable constant will be Attribute.Error, not Attribute.Constant, and there's an unguarded cast. The proposal herein is to improve error recovery by ignoring non-constant annotation attributes in Lint.suppressionsFrom. Such erroneous cases should have already been reported as compile-time errors anyway.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8361445: javac crashes on unresolvable constant in @SuppressWarnings

Issue

  • JDK-8361445: javac crashes on unresolvable constant in @SuppressWarnings (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26142/head:pull/26142
$ git checkout pull/26142

Update a local copy of the PR:
$ git checkout pull/26142
$ git pull https://git.openjdk.org/jdk.git pull/26142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26142

View PR using the GUI difftool:
$ git pr show -t 26142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26142.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361445: javac crashes on unresolvable constant in @SuppressWarnings

Reviewed-by: asotona, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2025
@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jul 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2025

Webrevs

@liach
Copy link
Member

liach commented Jul 6, 2025

Does this also cover using a non-String constant?

Comment on lines +533 to 538
Optional.of(value)
.filter(val -> val instanceof Attribute.Constant)
.map(val -> (String) ((Attribute.Constant) val).value)
.flatMap(LintCategory::get)
.filter(lc -> lc.annotationSuppression)
.ifPresent(result::add);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to do the following, which also fixes the non‑String case:

Suggested change
Optional.of(value)
.filter(val -> val instanceof Attribute.Constant)
.map(val -> (String) ((Attribute.Constant) val).value)
.flatMap(LintCategory::get)
.filter(lc -> lc.annotationSuppression)
.ifPresent(result::add);
if (value instanceof Attribute.Constant c && c.value instanceof String s) {
LintCategory.get(s)
.filter(lc -> lc.annotationSuppression)
.ifPresent(result::add);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to believe the non-String case is not covered by the current code? In the test, there is testSuppressWarningsErroneousAttribute2 which shows the current code works for non-String constant of type int, is there a case we can add to the tests showing the current code not working?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
Copy link
Member

@asotona asotona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lahodaj
Copy link
Contributor Author

lahodaj commented Jul 7, 2025

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@lahodaj Backport for repo openjdk/jdk on branch jdk25 was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

"Test.DOUBLE",
"Test.CHAR",
"Test.class",
"@Deprecated"
Copy link

@ExE-Boss ExE-Boss Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing enum constant test case:

Suggested change
"@Deprecated"
"E.A",
"@Deprecated",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks, fixed.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 8, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025
@lahodaj
Copy link
Contributor Author

lahodaj commented Jul 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

Going to push as commit 0bd2f9c.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2025
@openjdk openjdk bot closed this Jul 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@lahodaj Pushed as commit 0bd2f9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lahodaj
Copy link
Contributor Author

lahodaj commented Jul 8, 2025

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@lahodaj the backport was successfully created on the branch backport-lahodaj-0bd2f9cb-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0bd2f9cb from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 8 Jul 2025 and was reviewed by Adam Sotona and Chen Liang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-lahodaj-0bd2f9cb-jdk25:backport-lahodaj-0bd2f9cb-jdk25
$ git checkout backport-lahodaj-0bd2f9cb-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-lahodaj-0bd2f9cb-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants