-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361445: javac crashes on unresolvable constant in @SuppressWarnings #26142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
@lahodaj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Does this also cover using a non-String constant? |
Optional.of(value) | ||
.filter(val -> val instanceof Attribute.Constant) | ||
.map(val -> (String) ((Attribute.Constant) val).value) | ||
.flatMap(LintCategory::get) | ||
.filter(lc -> lc.annotationSuppression) | ||
.ifPresent(result::add); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to do the following, which also fixes the non‑String
case:
Optional.of(value) | |
.filter(val -> val instanceof Attribute.Constant) | |
.map(val -> (String) ((Attribute.Constant) val).value) | |
.flatMap(LintCategory::get) | |
.filter(lc -> lc.annotationSuppression) | |
.ifPresent(result::add); | |
if (value instanceof Attribute.Constant c && c.value instanceof String s) { | |
LintCategory.get(s) | |
.filter(lc -> lc.annotationSuppression) | |
.ifPresent(result::add); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to believe the non-String
case is not covered by the current code? In the test, there is testSuppressWarningsErroneousAttribute2
which shows the current code works for non-String
constant of type int
, is there a case we can add to the tests showing the current code not working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/backport :jdk25 |
@lahodaj Backport for repo |
"Test.DOUBLE", | ||
"Test.CHAR", | ||
"Test.class", | ||
"@Deprecated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing enum constant test case:
"@Deprecated" | |
"E.A", | |
"@Deprecated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks, fixed.
/integrate |
Going to push as commit 0bd2f9c.
Your commit was automatically rebased without conflicts. |
/backport :jdk25 |
@lahodaj the backport was successfully created on the branch backport-lahodaj-0bd2f9cb-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
Consider this code:
javac will crash attempting to compile it:
The reason is that the unresolvable constant will be
Attribute.Error
, notAttribute.Constant
, and there's an unguarded cast. The proposal herein is to improve error recovery by ignoring non-constant annotation attributes inLint.suppressionsFrom
. Such erroneous cases should have already been reported as compile-time errors anyway.Progress
Warning
8361445: javac crashes on unresolvable constant in @SuppressWarnings
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26142/head:pull/26142
$ git checkout pull/26142
Update a local copy of the PR:
$ git checkout pull/26142
$ git pull https://git.openjdk.org/jdk.git pull/26142/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26142
View PR using the GUI difftool:
$ git pr show -t 26142
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26142.diff
Using Webrev
Link to Webrev Comment