Skip to content

8361338: JFR: Min and max time in MethodTime event is confusing #26145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 6, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361338: JFR: Min and max time in MethodTime event is confusing (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26145/head:pull/26145
$ git checkout pull/26145

Update a local copy of the PR:
$ git checkout pull/26145
$ git pull https://git.openjdk.org/jdk.git pull/26145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26145

View PR using the GUI difftool:
$ git pr show -t 26145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26145.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361338: JFR: Min and max time in MethodTime event is confusing

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f3e0588d0b825a68a4ad61ddf806877f46da69dc 8361338: JFR: Min and max time in MethodTime event is confusing Jul 6, 2025
@openjdk
Copy link

openjdk bot commented Jul 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 6, 2025
@egahlin egahlin marked this pull request as ready for review July 6, 2025 19:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2025

Webrevs

Comment on lines +71 to +76
if (min == Long.MAX_VALUE) {
min = average;
}
if (max == Long.MIN_VALUE) {
max = average;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: I think Math.min/max below subsume these checks for Long.MAX/MIN_VALUE.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
@egahlin
Copy link
Member Author

egahlin commented Jul 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

Going to push as commit b3b5595.
Since your change was applied there have been 3 commits pushed to the jdk25 branch:

  • 5e716fd: 8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given
  • 3e93b98: 8354872: Clarify java.lang.Process resource cleanup
  • 9a73987: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2025
@openjdk openjdk bot closed this Jul 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@egahlin Pushed as commit b3b5595.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants