Skip to content

8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure() #26149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Jul 6, 2025

Hi all,

This pull request contains a backport of commit 7d7e60c8 from the openjdk/jdk repository.

The commit being backported was authored by Ioi Lam on 1 Jul 2025 and was reviewed by Calvin Cheung, Vladimir Kozlov and David Holmes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure() (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26149/head:pull/26149
$ git checkout pull/26149

Update a local copy of the PR:
$ git checkout pull/26149
$ git pull https://git.openjdk.org/jdk.git pull/26149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26149

View PR using the GUI difftool:
$ git pr show -t 26149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26149.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure()

Reviewed-by: shade, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk25 branch:

  • 9a73987: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7d7e60c8aebc4b4c1e7121be702393e5bc46e9ce 8360164: AOT cache creation crashes in ~ThreadTotalCPUTimeClosure() Jul 6, 2025
@openjdk
Copy link

openjdk bot commented Jul 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 6, 2025
@openjdk
Copy link

openjdk bot commented Jul 6, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@iklam
Copy link
Member Author

iklam commented Jul 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

Going to push as commit b896531.
Since your change was applied there have been 5 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2025
@openjdk openjdk bot closed this Jul 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@iklam Pushed as commit b896531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants