8361478: GHA: Use MSYS2 from GHA runners

[shipilev]

Installing MSYS2 takes considerable time in our Windows workflows. Fortunately, GHA runners currently ship with MSYS2 bundled! The docs for setup-msys2 step say it is enough to say release: false to use those:
https://github.com/msys2/setup-msys2?tab=readme-ov-file#release

Also bumping the action version to gain access to the actual installed path.

Additional testing:

• GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361478: GHA: Use MSYS2 from GHA runners (Enhancement - P4)

Reviewers

• Julian Waters (@TheShermanTanker - Committer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26156/head:pull/26156
$ git checkout pull/26156

Update a local copy of the PR:
$ git checkout pull/26156
$ git pull https://git.openjdk.org/jdk.git pull/26156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26156

View PR using the GUI difftool:
$ git pr show -t 26156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26156.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361478: GHA: Use MSYS2 from GHA runners

Reviewed-by: jwaters, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f05fd79f)
• 00: Full (32328a28)

[TheShermanTanker]

I recall there were some issues with using MSYS2 that comes with Actions. That was a long time ago though, are they no longer a problem with current Actions and MSYS2 versions?

[shipilev]

I recall there were some issues with using MSYS2 that comes with Actions. That was a long time ago though, are they no longer a problem with current Actions and MSYS2 versions?

We used to have a problem building jtreg, so we pinned and later unpinned the version: JDK-8310259. But today, we do not build jtreg on Windows at all. And we have not seen any issues with MSYS2 since. So I think it is okay to bump the version now. We can retract it back if we find problems, it would only require rewiring the PATH a bit awkwardly.

[TheShermanTanker]

I think the problem was something else about Actions MSYS2 not being usable, but alas I can't remember enough to actually make a valid point. So this gets a +1 from me since it can easily be backed out if it does cause issues. I'm not a Reviewer though, so you'll have to wait for Magnus to take a look at this

[shipilev]

Hey @magicus ;)

[magicus]

Sorry, on vacation. (I still am, just checking in here) This looks good though.

[shipilev]

Thanks! I am going to re-merge to confirm that GHA still works, and then integrate.

[shipilev]

/integrate

[openjdk]

Going to push as commit ed9066b.
Since your change was applied there have been 25 commits pushed to the master branch:

• 7a22b76: 8362591: Wrong argument warning when heap size larger than coops threshold
• 0ba2942: 8362838: RISC-V: Incorrect matching rule leading to improper oop instruction encoding
• fc80384: 8359827: Test runtime/Thread/ThreadCountLimit.java need loop increasing the limit
• ... and 22 more: https://git.openjdk.org/jdk/compare/d714b5d3dad58f7f6550d7a95fdc2b3f964a4129...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit ed9066b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.