Skip to content

8361836: RISC-V: Relax min vector length to 32-bit for short vectors #26239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jul 10, 2025

Follow up JDK-8359419, RVV supports all vector type conversion APIs in the Vector API.
So we only need to relax the length limit of the short type to achieve a significant improvement in JMH performance for converting between short and wider types.

Test

qemu-system UseRVV:

  • Run jdk_vector (fastdebug)
  • Run compiler/vectorapi (fastdebug)

Performance

Following shows the performance improvement of relative VectorAPI JMHs on k1 (256-bit RVV):

Benchmark                                             (SIZE)   Mode   Units   Before     After    Gain
VectorFPtoIntCastOperations.microDouble128ToShort128     512  thrpt  ops/ms   52.280   840.112   16.07
VectorFPtoIntCastOperations.microDouble128ToShort128    1024  thrpt  ops/ms   28.156   429.322   15.25
VectorFPtoIntCastOperations.microFloat64ToShort64        512  thrpt  ops/ms   14.242   479.509   33.67
VectorFPtoIntCastOperations.microFloat64ToShort64       1024  thrpt  ops/ms    6.906   242.690   35.14

PS: VectorFPtoIntCastOperations.microFloat64ToShort64 is added by JDK-8359419.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361836: RISC-V: Relax min vector length to 32-bit for short vectors (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26239/head:pull/26239
$ git checkout pull/26239

Update a local copy of the PR:
$ git checkout pull/26239
$ git pull https://git.openjdk.org/jdk.git pull/26239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26239

View PR using the GUI difftool:
$ git pr show -t 26239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26239.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2025

Webrevs

@@ -1994,6 +1994,9 @@ int Matcher::min_vector_size(const BasicType bt) {
} else if (bt == T_BOOLEAN) {
// To support vector api load/store mask.
size = 2;
} else if (bt == T_SHORT) {
// To support vector type conversions between short and wider types.
size = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some assert or guarantee for uncovered types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants