8356807: Change log_info(cds) to MetaspaceShared::report_loading_error()

[calvinccheung]

The patch changes some of the aot_log_info(aot)() to MetaspaceShared::report_loading_error() for those referring to an error condition during loading of AOT cache or CDS archive.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356807: Change log_info(cds) to MetaspaceShared::report_loading_error() (Enhancement - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer) Review applies to 1b55f8a4
• Matias Saavedra Silva (@matias9927 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26253/head:pull/26253
$ git checkout pull/26253

Update a local copy of the PR:
$ git checkout pull/26253
$ git pull https://git.openjdk.org/jdk.git pull/26253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26253

View PR using the GUI difftool:
$ git pr show -t 26253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26253.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356807: Change log_info(cds) to `MetaspaceShared::report_loading_error()`

Reviewed-by: matsaave, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 820263e: 8360701: Add bailout when the register allocator interference graph grows unreasonably large
• b65fdf5: 8358768: [vectorapi] Make VectorOperators.SUADD an Associative
• d2082c5: 8358621: Reduce busy waiting in worse case at the synchronization point returning from native in CPU Time Profiler
• ... and 57 more: https://git.openjdk.org/jdk/compare/518536c607cb383e810ee0f50f8af44e121f4ab3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (02cc330b)
• 02: Full - Incremental (1b55f8a4)
• 01: Full - Incremental (c85ff4ee)
• 00: Full (1e529f84)

[iklam]

LGTM.
I would suggest running tiers 5 and 6 as well, as some test cases may be sensitive to the messages that are printed in the "error" level by MetaspaceShared::report_loading_error()

[calvinccheung]

I noticed one test failure in tier5. Updated the ArchiveModuleWithCustomImageTest.java test.

[matias9927]

LGTM! Just one nit below

[matias9927]

The alignment was changed here.

[calvinccheung]

Line 2022 already ends at column 115. If I indent it more to the right to align with line 2021, the line will end past column 125. I will leave it as is.

[calvinccheung]

Fixed the indent per our offline discussion.

[matias9927]

Thanks for the fix, looks good!

[calvinccheung]

Thanks @iklam @matias9927 for the review.

/integrate

[openjdk]

Going to push as commit 38af17d.
Since your change was applied there have been 60 commits pushed to the master branch:

• 820263e: 8360701: Add bailout when the register allocator interference graph grows unreasonably large
• b65fdf5: 8358768: [vectorapi] Make VectorOperators.SUADD an Associative
• d2082c5: 8358621: Reduce busy waiting in worse case at the synchronization point returning from native in CPU Time Profiler
• ... and 57 more: https://git.openjdk.org/jdk/compare/518536c607cb383e810ee0f50f8af44e121f4ab3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 38af17d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.