-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java #26265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…face/IPv4Only.java
Hi @ayushrigal, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ayushrigal" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
@ayushrigal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 176 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@ayushrigal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@@ -35,6 +35,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a 2025
to the copyright at the top:
* Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.
@@ -35,6 +35,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Could you please change the wildcard imports to explicit ones
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
…face/IPv4Only.java
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test-only change to add a diagnostic log looks fine to me. Before integrating, please run this test in our CI, with your changes to make sure it continues to work as expected.
|
…face/IPv4Only.java
/integrate |
@ayushrigal |
/sponsor |
Going to push as commit 2f1aed2.
Your commit was automatically rebased without conflicts. |
@msheppar @ayushrigal Pushed as commit 2f1aed2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is part of a series of diagnostic output updates to java.net tests to assist in the analysis of failures in IPv6 only environments
for Linux there is not IPv4 configuration but the IPv4 stack remains enabled
For macOS, and windows the IPv4 stacks are disabled, and IPv4 configuration removed
add IPSupport::printPlatformSupport(System.out);
to the start of main
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26265/head:pull/26265
$ git checkout pull/26265
Update a local copy of the PR:
$ git checkout pull/26265
$ git pull https://git.openjdk.org/jdk.git pull/26265/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26265
View PR using the GUI difftool:
$ git pr show -t 26265
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26265.diff
Using Webrev
Link to Webrev Comment