Skip to content

8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java #26265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ayushrigal
Copy link
Contributor

@ayushrigal ayushrigal commented Jul 11, 2025

This is part of a series of diagnostic output updates to java.net tests to assist in the analysis of failures in IPv6 only environments
for Linux there is not IPv4 configuration but the IPv4 stack remains enabled
For macOS, and windows the IPv4 stacks are disabled, and IPv4 configuration removed

add IPSupport::printPlatformSupport(System.out);

to the start of main


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26265/head:pull/26265
$ git checkout pull/26265

Update a local copy of the PR:
$ git checkout pull/26265
$ git pull https://git.openjdk.org/jdk.git pull/26265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26265

View PR using the GUI difftool:
$ git pr show -t 26265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26265.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

Hi @ayushrigal, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ayushrigal" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@ayushrigal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 176 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title JDK-8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@ayushrigal The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jul 11, 2025
@@ -35,6 +35,7 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a 2025 to the copyright at the top:

 * Copyright (c) 2010, 2025, Oracle and/or its affiliates. All rights reserved.

@@ -35,6 +35,7 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Could you please change the wildcard imports to explicit ones

@ayushrigal
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jul 15, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jul 15, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test-only change to add a diagnostic log looks fine to me. Before integrating, please run this test in our CI, with your changes to make sure it continues to work as expected.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

⚠️ @ayushrigal the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8361423
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 22, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 22, 2025
@ayushrigal
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@ayushrigal
Your change (at version c688e55) is now ready to be sponsored by a Committer.

@msheppar
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

Going to push as commit 2f1aed2.
Since your change was applied there have been 176 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2025
@openjdk openjdk bot closed this Jul 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@msheppar @ayushrigal Pushed as commit 2f1aed2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants