Skip to content

8347052: Update java man page documentation to reflect current state of the UseNUMA flag #26321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 15, 2025

Hi all,

please review this small fix to the man pages that previously stated that UseNUMA is only available with Parallel GC. To minimize future update problems, the text has been modified to just say that the default value is dependent on the collector.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347052: Update java man page documentation to reflect current state of the UseNUMA flag (Bug - P4)(⚠️ The fixVersion in this issue is [25] but the fixVersion in .jcheck/conf is 26, a new backport will be created when this pr is integrated.)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26321/head:pull/26321
$ git checkout pull/26321

Update a local copy of the PR:
$ git checkout pull/26321
$ git pull https://git.openjdk.org/jdk.git pull/26321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26321

View PR using the GUI difftool:
$ git pr show -t 26321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26321.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this small fix to the man pages that previously stated that `UseNUMA` is only available with Parallel GC. To minimize future update problems, the text has been modified to just say that the default value is dependent on the collector.

Testing: local compilation

Thanks,
  Thomas
@tschatzl
Copy link
Contributor Author

/label add hotspot

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347052: Update java man page documentation to reflect current state of the UseNUMA flag

Reviewed-by: drwhite, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8347051 8347051: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails Jul 15, 2025
@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@tschatzl
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

@tschatzl tschatzl changed the title 8347051: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails 8347052 Jul 15, 2025
@openjdk openjdk bot changed the title 8347052 8347052: Update java man page documentation to reflect current state of the UseNUMA flag Jul 15, 2025
Copy link

@dwhite-intel dwhite-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Thomas.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025
@tschatzl
Copy link
Contributor Author

Thanks @dwhite-intel @albertnetymk for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit ea774b7.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@tschatzl Pushed as commit ea774b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8347052-usenuma-man-page branch July 17, 2025 13:48
@tschatzl
Copy link
Contributor Author

/backport jdk25

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@tschatzl The target repository jdk25 is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk24u, openjdk/jdk25u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx24u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

There is a branch jdk25 in the current repository openjdk/jdk.
To target a backport to this branch in the current repository use:
/backport :jdk25

@tschatzl
Copy link
Contributor Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@tschatzl the backport was successfully created on the branch backport-tschatzl-ea774b74-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ea774b74 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 17 Jul 2025 and was reviewed by Derek White and Albert Mingkun Yang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-tschatzl-ea774b74-jdk25:backport-tschatzl-ea774b74-jdk25
$ git checkout backport-tschatzl-ea774b74-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-tschatzl-ea774b74-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants