8362257: (process) Remove aliveness-ping-workaround for older glibcs in POSIX_SPAWN mode #26342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the liveness ping since it is not needed anymore for newer versions of glibc.
See JBS issue description for more details, and also for analysis of the major Linux distros wrt glibc version.
Patch also removes
throwExitCause()
, introduced with https://bugs.openjdk.org/browse/JDK-8226242 to analyze pre-exec abnormal abortions in jspawnhelper (see discussion about that removal at https://mail.openjdk.org/pipermail/core-libs-dev/2025-July/148908.html).We then can also remove the definitions for the waitpid status macros (WIFSIGNALED and so forth). These were remnants from the initial checkin, back at that time used for Java_java_lang_UNIXProcess_waitForProcessExit. That one has long been moved.
In
Java_java_lang_ProcessImpl_forkAndExec
, I modified the error-number-printout to preserve the specialized printout for jspawnhelper error codes introduced by Aleksey with JDK-8352533.Note: removing this code also fixes a path that would have caused Zombie processes to appear (see https://bugs.openjdk.org/browse/JDK-8362267 , which is a separate issue).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26342/head:pull/26342
$ git checkout pull/26342
Update a local copy of the PR:
$ git checkout pull/26342
$ git pull https://git.openjdk.org/jdk.git pull/26342/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26342
View PR using the GUI difftool:
$ git pr show -t 26342
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26342.diff