Skip to content

8362257: (process) Remove aliveness-ping-workaround for older glibcs in POSIX_SPAWN mode #26342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 16, 2025

Removes the liveness ping since it is not needed anymore for newer versions of glibc.

See JBS issue description for more details, and also for analysis of the major Linux distros wrt glibc version.

Patch also removes throwExitCause(), introduced with https://bugs.openjdk.org/browse/JDK-8226242 to analyze pre-exec abnormal abortions in jspawnhelper (see discussion about that removal at https://mail.openjdk.org/pipermail/core-libs-dev/2025-July/148908.html).

We then can also remove the definitions for the waitpid status macros (WIFSIGNALED and so forth). These were remnants from the initial checkin, back at that time used for Java_java_lang_UNIXProcess_waitForProcessExit. That one has long been moved.

In Java_java_lang_ProcessImpl_forkAndExec, I modified the error-number-printout to preserve the specialized printout for jspawnhelper error codes introduced by Aleksey with JDK-8352533.

Note: removing this code also fixes a path that would have caused Zombie processes to appear (see https://bugs.openjdk.org/browse/JDK-8362267 , which is a separate issue).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362257: (process) Remove aliveness-ping-workaround for older glibcs in POSIX_SPAWN mode (Enhancement - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26342/head:pull/26342
$ git checkout pull/26342

Update a local copy of the PR:
$ git checkout pull/26342
$ git pull https://git.openjdk.org/jdk.git pull/26342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26342

View PR using the GUI difftool:
$ git pr show -t 26342

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26342.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8362257: (process) Remove aliveness-ping-workaround for older glibcs in POSIX_SPAWN mode 8362257: (process) Remove aliveness-ping-workaround for older glibcs in POSIX_SPAWN mode Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 16, 2025
@tstuefe tstuefe closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant