8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) #26353

bplb · 2025-07-16T16:54:55Z

Address the same problem as in #26224 but for the listFiles variants with a filter parameter.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) (Bug - P2)

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26353/head:pull/26353
$ git checkout pull/26353

Update a local copy of the PR:
$ git checkout pull/26353
$ git pull https://git.openjdk.org/jdk.git pull/26353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26353

View PR using the GUI difftool:
$ git pr show -t 26353

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26353.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-07-16T16:55:53Z

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-16T16:56:15Z

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

bc72f47: 8362088: CompressedKlassPointers::encode should be const correct
a65d953: 8309399: JVMTI spec needs to clarify when OPAQUE_FRAME is thrown for reasons other than a native method
20b5f09: 8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent
... and 1 more: https://git.openjdk.org/jdk/compare/8193856af8546332bfa180cb45154a4093b4fd2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-07-16T16:56:57Z

@bplb The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-07-16T17:00:23Z

Webrevs

AlanBateman · 2025-07-16T18:26:51Z

src/java.base/share/classes/java/io/File.java

+            for (String s : ss) {
+                File f = new File(s, this);
+                if ((filter == null) || filter.accept(f))
+                    files.add(f);


Rather than duplicating the loop, it could be changed to introduce boolean isEmpty = path.isEmpty and then the f can be created with File f = isEmpty ? new File(s) : new File(this, s); It should be a bit cleaner.

I had rejected that in the case of the parameter-less listFiles to avoid a ternary operator in each loop iteration but it is cleaner. Will update.

So changed in cfd494f.

AlanBateman · 2025-07-16T18:31:59Z

test/jdk/java/io/File/EmptyPath.java

+    public void listFilesFilenameFilter() throws IOException {
+        listFiles(x -> x.listFiles((FilenameFilter)null));
+    }
+


What would you think about test a non-null filter too?

What would you think about test a non-null filter too?

Okay.

Add listFiles tests for non-null FileFilter and FilenameFilter in cfd494f.

bplb · 2025-07-17T06:31:20Z

/integrate

openjdk · 2025-07-17T06:31:37Z

Going to push as commit be0161a.
Since your change was applied there have been 4 commits pushed to the master branch:

bc72f47: 8362088: CompressedKlassPointers::encode should be const correct
a65d953: 8309399: JVMTI spec needs to clarify when OPAQUE_FRAME is thrown for reasons other than a native method
20b5f09: 8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent
... and 1 more: https://git.openjdk.org/jdk/compare/8193856af8546332bfa180cb45154a4093b4fd2c...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-07-17T06:31:47Z

@bplb Pushed as commit be0161a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

bplb · 2025-07-17T06:32:19Z

/backport :jdk25

openjdk · 2025-07-17T06:33:12Z

@bplb the backport was successfully created on the branch backport-bplb-be0161a8-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit be0161a8 from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 17 Jul 2025 and was reviewed by Alan Bateman.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-bplb-be0161a8-jdk25:backport-bplb-be0161a8-jdk25
$ git checkout backport-bplb-be0161a8-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-bplb-be0161a8-jdk25

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter)

f10f396

openjdk bot added the rfr Pull request is ready for review label Jul 16, 2025

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 16, 2025

8362429: Add list(FilenameFilter) and toURL()

1c61743

AlanBateman reviewed Jul 16, 2025

View reviewed changes

8362429: Simplify listFile loops; add non-null filter tests

cfd494f

AlanBateman approved these changes Jul 17, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025

openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025

openjdk bot closed this Jul 17, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025

bplb deleted the listFiles-filter-8362429 branch July 17, 2025 17:19

bplb mentioned this pull request Jul 18, 2025

8361587: AssertionError in File.listFiles() when path is empty and -esa is enabled #26224

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) #26353

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) #26353

Uh oh!

bplb commented Jul 16, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jul 16, 2025

Uh oh!

openjdk bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jul 16, 2025

Uh oh!

mlbridge bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

AlanBateman Jul 16, 2025

Uh oh!

bplb Jul 16, 2025

Uh oh!

bplb Jul 16, 2025

Uh oh!

AlanBateman Jul 16, 2025

Uh oh!

bplb Jul 16, 2025

Uh oh!

bplb Jul 16, 2025

Uh oh!

bplb commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

bplb commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

Uh oh!

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) #26353

8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter) #26353

Uh oh!

Conversation

bplb commented Jul 16, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 16, 2025

Uh oh!

openjdk bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 16, 2025

Uh oh!

mlbridge bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

AlanBateman Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

bplb Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

bplb Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

AlanBateman Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

bplb Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

bplb Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

bplb commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

bplb commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

Uh oh!

bplb commented Jul 16, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jul 16, 2025 •

edited

Loading

mlbridge bot commented Jul 16, 2025 •

edited

Loading