-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add @Stable to LocaleProviderAdapter #26354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wenshao
wants to merge
10
commits into
openjdk:master
Choose a base branch
from
wenshao:locale_stable_202507
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+163
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Welcome back swen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read @minberg 's PR #25727 (JDK-8359119: Change Charset to use StableValue ) and found that LocaleProviderAdapter can also be optimized.
In this way, calls like the following can fold away unnecessary branches
In the JRELocaleProviderAdapter::getLocaleServiceProvider method, use multiple ifs instead of switch(String) so that CodeSize < 325 can be inlined
Add @stable to the immutable fields of FallbackLocaleProviderAdapter/JRELocaleProviderAdapter/CLDRLocaleProviderAdapter
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26354/head:pull/26354
$ git checkout pull/26354
Update a local copy of the PR:
$ git checkout pull/26354
$ git pull https://git.openjdk.org/jdk.git pull/26354/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26354
View PR using the GUI difftool:
$ git pr show -t 26354
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26354.diff