Skip to content

8345836: Stable annotation documentation is incomplete #26355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Jul 16, 2025

Please review this documentation update, authored by @rose00 and originally pushed to the Leyden repo in this PR, where more comments can be found regarding this update.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345836: Stable annotation documentation is incomplete (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26355/head:pull/26355
$ git checkout pull/26355

Update a local copy of the PR:
$ git checkout pull/26355
$ git pull https://git.openjdk.org/jdk.git pull/26355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26355

View PR using the GUI difftool:
$ git pr show -t 26355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26355.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@iklam
Copy link
Member Author

iklam commented Jul 16, 2025

/author set @rose00

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345836: Stable annotation documentation is incomplete

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2025
@iklam iklam changed the title 8345836: stable annotation documentation is incomplete 8345836: Stable annotation documentation is incomplete Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@iklam
Setting overriding author to John R Rose <jrose@openjdk.org>. When this pull request is integrated, the overriding author will be used in the commit.

@openjdk openjdk bot changed the title 8345836: Stable annotation documentation is incomplete 8345836: stable annotation documentation is incomplete Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@iklam The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 16, 2025
@openjdk openjdk bot changed the title 8345836: stable annotation documentation is incomplete 8345836: Stable annotation documentation is incomplete Jul 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2025
@iklam
Copy link
Member Author

iklam commented Jul 18, 2025

Thanks @liach for the review
/integrate

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

Going to push as commit d83346d.
Since your change was applied there have been 58 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2025
@openjdk openjdk bot closed this Jul 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@iklam Pushed as commit d83346d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants