8364973: Add JVMTI stress testing mode #26360

lmesnik · 2025-07-17T02:39:15Z

The fix added JVMTI stress testing mode.

This mode enables stress agent that could be executed with jtreg test and help to ensure that jvmti functionality doesn't break the other JVM/JDK functionality.

I filed few issues and more are coming. I want to push the agent so it is possible to provide reproduces for problems uncovered by this agent.

The agent has 2 modes now:

regular that is compatible with most of tests including other jvmti, jdi and jdb tests
debugger, that additionally test some function requiring solo capabilities and not compatible with debugger and some jvmti tests

The tests incompatible wiht agent (IR, CDS) and some individual tests from tier1 are excluded. There are not plans to support stable execution of all tests with agent right now. However it provokes some crashes worth to be used for exploratory testing.
Note, that flagless tests are excluded automatically and not executed in this mode.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8364973: Add JVMTI stress testing mode (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26360/head:pull/26360
$ git checkout pull/26360

Update a local copy of the PR:
$ git checkout pull/26360
$ git pull https://git.openjdk.org/jdk.git pull/26360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26360

View PR using the GUI difftool:
$ git pr show -t 26360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26360.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-07-17T02:40:04Z

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-17T02:40:25Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2025-07-17T02:40:55Z

@lmesnik The following label will be automatically applied to this pull request:

build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

…ress-agent

This reverts commit 014e4e4.

…ress-agent

lmesnik · 2025-08-07T05:50:04Z

/cc serviceability

openjdk · 2025-08-07T05:50:15Z

@lmesnik
The serviceability label was successfully added.

mlbridge · 2025-08-07T05:54:52Z

Webrevs

make/RunTests.gmk

erikj79 · 2025-08-08T13:24:50Z

make/RunTests.gmk

-# Setup _NT_SYMBOL_PATH on Windows, which points to our pdb files.
-ifeq ($(call isTargetOs, windows), true)
-  ifndef _NT_SYMBOL_PATH
-    SYMBOL_PATH := $(call PathList, $(sort $(patsubst %/, %, $(dir $(wildcard \
-        $(addprefix $(SYMBOLS_IMAGE_DIR)/bin/, *.pdb */*.pdb))))))
-    export _NT_SYMBOL_PATH := $(subst \\,\, $(call FixPath, \
-        $(subst $(DQUOTE),, $(SYMBOL_PATH))))
-    $(call LogDebug, Setting _NT_SYMBOL_PATH to $(_NT_SYMBOL_PATH))
-  endif
-endif
-


What happened here?

erikj79 · 2025-08-08T13:29:52Z

make/RunTests.gmk

+    AGENT := $${LIBRARY_PREFIX}JvmtiStressAgent${SHARED_LIBRARY_SUFFIX}=$${JTREG_JVMTI_STRESS_AGENT}
+    $1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:${TEST_IMAGE_DIR}/hotspot/jtreg/native/$${AGENT}'
+    $1_JTREG_BASIC_OPTIONS += $$(addprefix $$(JTREG_PROBLEM_LIST_PREFIX), $$(wildcard \
+	$$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \
+    ))


You need to add the definitions of LIBRARY_PREFIX and SHARED_LIBRARY_SUFFIX for this to work in a remote testing situation.

I asked you to not use {} but () when referencing variables in makefiles.

There is no continuation indentation here, please adjust.

magicus · 2025-08-11T09:24:27Z

make/RunTests.gmk

@@ -876,6 +877,15 @@ define SetupRunJtregTestBody
    ))
  endif

+  ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
+    AGENT := $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)
+    $1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:${TEST_IMAGE_DIR}/hotspot/jtreg/native/$${AGENT}'


Suggested change

$1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:${TEST_IMAGE_DIR}/hotspot/jtreg/native/$${AGENT}'

$1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:$(TEST_IMAGE_DIR)/hotspot/jtreg/native/$$(AGENT)'

Also, this line looks quite long. Can you check that it does not pass 80 characters? (Can't tell on github reviews...)

magicus · 2025-08-11T09:25:57Z

make/RunTests.gmk

+	$$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \
+    ))


Suggested change

$$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \

))

$$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \

))

Also, the comment on line length applies here.

magicus · 2025-08-11T09:27:36Z

test/lib/jdk/test/lib/jvmti/libJvmtiStressAgent.cpp

+ *
+ * Test supports 2 modes:
+ *   - standard, where the agent doesn't require debugging capabilities
+ *   - debug, where the agent  additionally test debug-related functionality


Suggested change

* - debug, where the agent additionally test debug-related functionality

* - debug, where the agent additionally test debug-related functionality

magicus · 2025-08-11T09:27:50Z

test/lib/jdk/test/lib/jvmti/libJvmtiStressAgent.cpp

+ *   - standard, where the agent doesn't require debugging capabilities
+ *   - debug, where the agent  additionally test debug-related functionality
+ *   The debug mode is incompatible with debugger tests and debug jvmti tests.
+ *   The standard mode should be compatible with all tests except probelmlisted.


Suggested change

* The standard mode should be compatible with all tests except probelmlisted.

* The standard mode should be compatible with all tests except problemlisted.

magicus · 2025-08-11T09:35:09Z

make/RunTests.gmk

@@ -876,6 +877,15 @@ define SetupRunJtregTestBody
    ))
  endif

+  ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
+    AGENT := $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)


I don't understand the usage scenario here. Are you supposed to run this like make test JTREG=JVMTI_STRESS_AGENT=true? If so, this will result in -javaoption:'-agentpath:<test-image>/hotspot/jtreg/native/libJvmtiStressAgent.so=true being sent to jtreg, and that looks sus.

Or how should this be used?

In fact, this option should be described in testing.md.

This is a jtreg agent options, I use it like
JTREG_JVMTI_STRESS_AGENT=debugger=false
or
JTREG_JVMTI_STRESS_AGENT=debugger=true,verbose
Any of options enable jvmti agent and parsed by it.
I don't want to add 2 options, for hits. The JTREG_JVMTI_STRESS_AGENT=false doesn't make any sense.

The options are defined by stress agent while makefile just propagate them to the agent.

lmesnik

Thank you feedback, I explained the usage of
JTREG_JVMTI_STRESS_AGENT
and applied your changes.

lmesnik · 2025-08-11T19:31:05Z

make/RunTests.gmk

@@ -876,6 +877,15 @@ define SetupRunJtregTestBody
    ))
  endif

+  ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
+    AGENT := $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)


This is a jtreg agent options, I use it like
JTREG_JVMTI_STRESS_AGENT=debugger=false
or
JTREG_JVMTI_STRESS_AGENT=debugger=true,verbose
Any of options enable jvmti agent and parsed by it.
I don't want to add 2 options, for hits. The JTREG_JVMTI_STRESS_AGENT=false doesn't make any sense.

The options are defined by stress agent while makefile just propagate them to the agent.

first version of jvmti stress agent

74a0751

openjdk bot added the build build-dev@openjdk.org label Jul 17, 2025

lmesnik added 16 commits July 16, 2025 20:12

removed typo

6cfa190

Merge branch 'master' of https://github.com/openjdk/jdk into jvmti-st…

2c2ffd9

…ress-agent

update

4eaae9d

The more clean up.

9aee241

fixed phase

ede07c8

added settings

9bc7a60

more fixes

65a6426

lib updated

d23f2e9

updated struct to c++

014e4e4

fixed vm death

5f7a1e4

Merge branch 'master' of https://github.com/openjdk/jdk into jvmti-st…

e891f7a

…ress-agent

Revert "updated struct to c++"

829af9e

This reverts commit 014e4e4.

fixed small issues

262aa48

Merge branch 'master' of https://github.com/openjdk/jdk into jvmti-st…

6badb2c

…ress-agent

fixed IR framework

4c23432

problemlist and exclusion fiexd.

cb9c645

lmesnik changed the title ~~first version of jvmti stress agent~~ 8364973: Add JVMTI stress testing mode Aug 7, 2025

lmesnik marked this pull request as ready for review August 7, 2025 05:49

openjdk bot added the serviceability serviceability-dev@openjdk.org label Aug 7, 2025

openjdk bot added the rfr Pull request is ready for review label Aug 7, 2025

erikj79 reviewed Aug 7, 2025

View reviewed changes

make/RunTests.gmk Outdated Show resolved Hide resolved

make/RunTests.gmk Outdated Show resolved Hide resolved

make/RunTests.gmk Outdated Show resolved Hide resolved

makefiles fixed

6d505a8

erikj79 reviewed Aug 8, 2025

View reviewed changes

fixed makefiles

49c2a67

magicus reviewed Aug 11, 2025

View reviewed changes

lmesnik commented Aug 11, 2025

View reviewed changes

	$1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:${TEST_IMAGE_DIR}/hotspot/jtreg/native/$${AGENT}'
	$1_JTREG_BASIC_OPTIONS += -javaoption:'-agentpath:$(TEST_IMAGE_DIR)/hotspot/jtreg/native/$$(AGENT)'

		$$(addprefix $$($1_TEST_ROOT)/, ProblemList-jvmti-stress-agent.txt) \
		))

	* - debug, where the agent additionally test debug-related functionality
	* - debug, where the agent additionally test debug-related functionality

	* The standard mode should be compatible with all tests except probelmlisted.
	* The standard mode should be compatible with all tests except problemlisted.

8364973: Add JVMTI stress testing mode #26360

Are you sure you want to change the base?

8364973: Add JVMTI stress testing mode #26360

Conversation

lmesnik commented Jul 17, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper bot commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

openjdk bot commented Jul 17, 2025

Uh oh!

lmesnik commented Aug 7, 2025

Uh oh!

openjdk bot commented Aug 7, 2025

Uh oh!

mlbridge bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmesnik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lmesnik commented Jul 17, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Aug 7, 2025 •

edited

Loading