8370628: Rename BigInteger::nthRoot to rootn, and similarly for nthRootAndRemainder

[rgiulietti]

The reason for this last minute renaming is to more closely adhere to the IEEE 754 nomenclature, even in the BigInteger class (and in the internal MutableBigInteger).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8370629 to be approved

Issues

• JDK-8370628: Rename BigInteger::nthRoot to rootn, and similarly for nthRootAndRemainder (Enhancement - P4)
• JDK-8370629: Rename BigInteger::nthRoot to rootn, and similarly for nthRootAndRemainder (CSR)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27980/head:pull/27980
$ git checkout pull/27980

Update a local copy of the PR:
$ git checkout pull/27980
$ git pull https://git.openjdk.org/jdk.git pull/27980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27980

View PR using the GUI difftool:
$ git pr show -t 27980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27980.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370628: Rename BigInteger::nthRoot to rootn, and similarly for nthRootAndRemainder

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• c3449de: 8360395: sun/security/tools/keytool/i18n.java user country is current user location instead of the language
• 32697bf: 8370501: vmTestbase/vm/gc/compact/Humongous_NonbranchyTree5M/TestDescription.java intermittent timed out
• 35fdda0: 7105350: HttpExchange's attributes are the same as HttpContext's attributes
• ... and 3 more: https://git.openjdk.org/jdk/compare/13adcd99db4f14caf90de7f59e341380cfa354b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ed9ff931)
• 00: Full (801e4440)

[rgiulietti]

/integrate

[openjdk]

Going to push as commit e9479b5.
Since your change was applied there have been 10 commits pushed to the master branch:

• f5ef01d: 8370368: Apply java.io.Serial annotations in java.security.jgss
• 3d2ce80: 8212084: G1: Implement UseGCOverheadLimit
• bfc1db7: 8370560: Remove non-public API reference from public API javadoc
• ... and 7 more: https://git.openjdk.org/jdk/compare/13adcd99db4f14caf90de7f59e341380cfa354b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit e9479b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.