Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 24, 2025

Test
com/sun/jdi/TwoThreadsTest.java
start new threads using DebuggeeWrapper.newThread()
and exit immediately.

It is needed to jon() threads so test really works for virtual threads.

I looked on other threads that use DebuggeeWrapper.newThread(). Seems most of them already updated to join spawned threads.

Tested by running test on all platfrom with and wihtout virtual threads.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370636: com/sun/jdi/TwoThreadsTest.java should wait for completion of all threads (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27982/head:pull/27982
$ git checkout pull/27982

Update a local copy of the PR:
$ git checkout pull/27982
$ git pull https://git.openjdk.org/jdk.git pull/27982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27982

View PR using the GUI difftool:
$ git pr show -t 27982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27982.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370636: com/sun/jdi/TwoThreadsTest.java should wait for completion of all threads

Reviewed-by: syan, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2025

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2025

t1.start();
t2.start();
// The threads might be virutal and daemon, so wait until completion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"virutal" is misspelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants