-
Couldn't load subscription status.
- Fork 6.1k
8370636: com/sun/jdi/TwoThreadsTest.java should wait for completion of all threads #27982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
|
@lmesnik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
|
||
| t1.start(); | ||
| t2.start(); | ||
| // The threads might be virutal and daemon, so wait until completion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"virutal" is misspelled.
Test
com/sun/jdi/TwoThreadsTest.java
start new threads using DebuggeeWrapper.newThread()
and exit immediately.
It is needed to jon() threads so test really works for virtual threads.
I looked on other threads that use DebuggeeWrapper.newThread(). Seems most of them already updated to join spawned threads.
Tested by running test on all platfrom with and wihtout virtual threads.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27982/head:pull/27982$ git checkout pull/27982Update a local copy of the PR:
$ git checkout pull/27982$ git pull https://git.openjdk.org/jdk.git pull/27982/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27982View PR using the GUI difftool:
$ git pr show -t 27982Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27982.diff
Using Webrev
Link to Webrev Comment