Skip to content

8355740: Update to Xcode 15.4 on macOS #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 28, 2025

This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match JDK 25.

I ran a full headless and headful test run, including building media and WebKit. No issues were found.

NOTE: Xcode 15.4 requires macOS 14 Sonoma to build (although it is known to build on macOS 13, which might be useful for developer builds). The generated JavaFX code will run on older versions of macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8355740: Update to Xcode 15.4 on macOS (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1798/head:pull/1798
$ git checkout pull/1798

Update a local copy of the PR:
$ git checkout pull/1798
$ git pull https://git.openjdk.org/jfx.git pull/1798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1798

View PR using the GUI difftool:
$ git pr show -t 1798

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1798.diff

Using Webrev

Link to Webrev Comment

@kevinrushforth kevinrushforth changed the title 8355740 xcode 15.4 8355740 Apr 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8355740 8355740: Update to Xcode 15.4 on macOS Apr 28, 2025
@kevinrushforth
Copy link
Member Author

Reviewers: @arapte @tiainen

/reviewers 2

@kevinrushforth kevinrushforth marked this pull request as ready for review May 19, 2025 15:58
@openjdk openjdk bot added the rfr Ready for review label May 19, 2025
@openjdk
Copy link

openjdk bot commented May 19, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented May 19, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant