-
Notifications
You must be signed in to change notification settings - Fork 513
8356042: RichTextArea: tab stops attributes #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8356042: RichTextArea: tab stops attributes #1800
Conversation
This reverts commit 0e9e8ee.
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
* | ||
* @since 999 TODO | ||
*/ | ||
public class TabStop { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this immutable, why not use a record
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question!
I see no value here in making it a record, and I think there is a possibility for an application to extend TabStop in order to provide additional attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this thing is still in Draft, but thank you for checking up on it!)
|
RichTextArea
RichEditorDemoApp
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1800/head:pull/1800
$ git checkout pull/1800
Update a local copy of the PR:
$ git checkout pull/1800
$ git pull https://git.openjdk.org/jfx.git pull/1800/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1800
View PR using the GUI difftool:
$ git pr show -t 1800
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1800.diff