Skip to content

8356042: RichTextArea: tab stops attributes #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented May 1, 2025

  • adds tab stops paragraph attributes to the RichTextArea
  • adds a ruler to the RichEditorDemoApp

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356042: RichTextArea: tab stops attributes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1800/head:pull/1800
$ git checkout pull/1800

Update a local copy of the PR:
$ git checkout pull/1800
$ git pull https://git.openjdk.org/jfx.git pull/1800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1800

View PR using the GUI difftool:
$ git pr show -t 1800

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1800.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

*
* @since 999 TODO
*/
public class TabStop {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this immutable, why not use a record instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question!

I see no value here in making it a record, and I think there is a possibility for an application to extend TabStop in order to provide additional attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this thing is still in Draft, but thank you for checking up on it!)

@openjdk
Copy link

openjdk bot commented May 19, 2025

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants