8425: Problem importing in Eclipse due to missing awatility 3rd party artifact

[skarsaune]

The Jolokia test plugin requires awaitility

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8425: Problem importing in Eclipse due to missing awatility 3rd party artifact (Bug - P4)

Reviewers

• Alex Macdonald (@aptmac - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668
$ git checkout pull/668

Update a local copy of the PR:
$ git checkout pull/668
$ git pull https://git.openjdk.org/jmc.git pull/668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 668

View PR using the GUI difftool:
$ git pr show -t 668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/668.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@skarsaune This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8425: Problem importing in Eclipse due to missing awatility 3rd party artifact

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2bb16fa: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@viragpurnam, @aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (f872fb9e)
• 01: Full - Incremental (863ab4aa)
• 00: Full (8e3e4a32)

[viragpurnam]

Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.

[bridgekeeper]

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[skarsaune]

Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.

@viragpurnam : Hmm, this is a test requirement, only needed by a test plugin. So it should not be shipped as part of the product. If it works like this it is fine, if not we have to look at some other mechanism.

[thegreystone]

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

[skarsaune]

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

Ok, I can try to include it

[bridgekeeper]

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[aptmac]

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

Ok, I can try to include it

The platform-definition-*.target files will just need a <unit id="org.awaitility" version="4.0.0"/> added somewhere in the <repository location="http://localhost:8080/site"/> section.

[skarsaune]

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

Ok, I can try to include it

The platform-definition-*.target files will just need a <unit id="org.awaitility" version="4.0.0"/> added somewhere in the <repository location="http://localhost:8080/site"/> section.

Added in latest commit

[skarsaune]

PR was closed by misclick on my part. Reopened now.

[aptmac]

Looks good, sorry I missed this but there's one last nit here: the commit and ticket have a typo in "artefact" -> "artifact". Should be good to go after that.

[skarsaune]

@aptmac Nice catch. Will fix once I'm back at my computer

[skarsaune]

Done

[skarsaune]

/integrate

[openjdk]

@skarsaune
Your change (at version f872fb9) is now ready to be sponsored by a Committer.

[aptmac]

/sponsor

[openjdk]

Going to push as commit 3922e8a.
Since your change was applied there has been 1 commit pushed to the master branch:

• 2bb16fa: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions

Your commit was automatically rebased without conflicts.

[openjdk]

@aptmac @skarsaune Pushed as commit 3922e8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.