Skip to content

Conversation

aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Oct 10, 2025

When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.

Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.

Two potential workarounds are :

  • Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
    (This impacts only the chart in question.)
  • Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
    (This impacts all charts.)

I followed the first strategy.

Screenshot of processes page post change :

Screenshot 2025-10-10 at 17 02 40

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8427: Text getting overlapped on graph of Processes screen (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/678/head:pull/678
$ git checkout pull/678

Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.org/jmc.git pull/678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 678

View PR using the GUI difftool:
$ git pr show -t 678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/678.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Oct 10, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant