8427: Text getting overlapped on graph of Processes screen #678
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.
Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.
Two potential workarounds are :
(This impacts only the chart in question.)
(This impacts all charts.)
I followed the first strategy.
Screenshot of processes page post change :
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/678/head:pull/678
$ git checkout pull/678
Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.org/jmc.git pull/678/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 678
View PR using the GUI difftool:
$ git pr show -t 678
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/678.diff
Using Webrev
Link to Webrev Comment