Skip to content

PodProbeMarker Support http/tcp capacities #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmberg opened this issue Jun 5, 2023 · 4 comments · May be fixed by #2003
Open

PodProbeMarker Support http/tcp capacities #1306

zmberg opened this issue Jun 5, 2023 · 4 comments · May be fixed by #2003
Assignees
Milestone

Comments

@zmberg
Copy link
Member

zmberg commented Jun 5, 2023

What would you like to be added:
PodProbeMarker currently only support exec model, so need support tcp/http model, for example:

apiVersion: apps.kruise.io/v1alpha1
kind: PodProbeMarker
metadata:
  name: game-server-probe
  namespace: ns
spec:
  selector:
    matchLabels:
      app: game-server
  probes:
  - name: Idle
    containerName: game-server
    probe:
      tcpSocket:
        port: 80
      httpGet:
        path: /healthz
        port: 80
        scheme: HTTP
      initialDelaySeconds: 30
      periodSeconds: 10
      timeoutSeconds: 5
    markerPolicy:
    ...

Related codes: https://github.com/openkruise/kruise/tree/master/pkg/daemon/podprobe

@furykerry furykerry changed the title [feature request] PodProbeMarker Support http/tcp capacities [GLCC][feature request] PodProbeMarker Support http/tcp capacities Jun 5, 2023
@zmberg zmberg changed the title [GLCC][feature request] PodProbeMarker Support http/tcp capacities [GLCC] PodProbeMarker Support http/tcp capacities Jun 5, 2023
@nitishchauhan0022
Copy link
Contributor

/assign

@zmberg zmberg changed the title [GLCC] PodProbeMarker Support http/tcp capacities PodProbeMarker Support http/tcp capacities Jun 19, 2023
@ABNER-1 ABNER-1 added this to the 1.9 milestone Apr 17, 2025
@kagaya85
Copy link

Hi @ABNER-1, is there anyone still working on this issue? I just wanted to let you know that maybe I can try to complete it. :)

@furykerry
Copy link
Member

tcp probe is supported, but http probe is still not supported, it seems that no one is working on this issue, we can reassign the issue to you if you are willing to do it

@kagaya85
Copy link

Thanks, let me give it a try.

@kagaya85 kagaya85 linked a pull request Apr 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment