Skip to content

[WIP]Optimize Inplace-VPA E2E Case: Add Wait Rule or Adjust Expected State #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Apr 18, 2025

Ⅰ. Describe what this PR does

  1. resources or containersStatus in status keeping changing
  2. last state missing

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
@kruise-bot kruise-bot requested review from furykerry and zmberg April 18, 2025 03:37
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.55%. Comparing base (e149b48) to head (8187610).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
+ Coverage   42.75%   43.55%   +0.80%     
==========================================
  Files         315      316       +1     
  Lines       31401    31467      +66     
==========================================
+ Hits        13427    13707     +280     
+ Misses      16601    16366     -235     
- Partials     1373     1394      +21     
Flag Coverage Δ
unittests 43.55% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kruise-bot kruise-bot added size/XXL and removed size/M size/M: 30-99 labels Apr 18, 2025
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
@ABNER-1 ABNER-1 force-pushed the opt-inplace-vpa-e2e1 branch from e266ffe to 8187610 Compare April 23, 2025 03:28
@ABNER-1 ABNER-1 changed the title Optimize Inplace-VPA E2E Case: Add Wait Rule or Adjust Expected State [WIP]Optimize Inplace-VPA E2E Case: Add Wait Rule or Adjust Expected State May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants