Skip to content

Reinstating pagination functionality #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reinstating pagination functionality #15

wants to merge 4 commits into from

Conversation

Allentro
Copy link
Collaborator

Reinstated pagination.

A few choices I made are:

  • Only show current page in the centre of pagination (prevented styling issues with 4 digit numbers)
  • Swapped out indexes for ids. Indexes aren't tracked when I changed tab so would lost data selected previously.
  • Pulled some of the filtering logic from the filtered data function. (This should have been a separate PR but got caught up.. Feel free to reject this).

@shimwell
Copy link
Member

Would it be possible to break out the PR into a few PRs please. I'm struggling to review.

Could we make a PR that does the swapping of indexes for IDs first please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Allentro @shimwell