Skip to content

Conversation

@shimwell
Copy link
Member

@shimwell shimwell commented Nov 21, 2025

Description

It have just added a minimal set of extra options to the Material constructor to allow a material to made from the constructor.

This is useful to myself as I have a json representation of the material and going to a material object is easier with this addition. It also follows on some work @eepeterson and myself were doing trying to allow more classes to be construct-able from the constructor.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
Copy link
Member Author

shimwell commented Nov 24, 2025

edited this PR
I had originally added nuclides to the constructor but have now removed that as there are a few ways go about the addition of elements/nuclides and I would now like to do that in a follow up PR to keep this one as minimal as possible. I think this makes it easier to consider for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants