O3-1494: Fixed invalid format in date parameters #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen this is the fix for incorrect date format that has been noticed recently by one of the user |
ibacher
reviewed
Mar 13, 2025
There was a problem hiding this comment.
Thanks @druchniewicz! Couple of suggestions for how to do this.
| name={parameter.name} | ||
| labelText={parameter.label} | ||
| type="text" | ||
| pattern="\d{4}-\d{2}-\d{2}" |
There was a problem hiding this comment.
Strongly prefer that we don't try to enforce a pattern here at all.
Comment on lines
133
to
143
| const formattedDate = formatLocalDateToString(dateValue); | ||
| setReportParameters((state) => ({ ...state, [fieldName]: formattedDate })); | ||
| } | ||
|
|
||
| function formatLocalDateToString(dateValue) { | ||
| const date = new Date(dateValue); | ||
| const year = date.getFullYear(); | ||
| const month = String(date.getMonth() + 1).padStart(2, '0'); | ||
| const day = String(date.getDate()).padStart(2, '0'); | ||
|
|
||
| return `${year}-${month}-${day}`; |
There was a problem hiding this comment.
We tend to prefer using dayjs, which makes this relatively easy, but for preference, we should be using the functions built into the framework such as formatDate to avoid hard-coding date formats and calendars where they are not appropriate.
|
@denniskigen @ibacher PR updated. Can you take a look? |
|
@ibacher @denniskigen PR corrected, can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected values in date parameters in the report were automatically treated as incorrect format.