Skip to content
This repository was archived by the owner on Jun 26, 2025. It is now read-only.

(fix) O3-4159: Workspace should not cover content on service queues page #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(fix) O3-4159: Workspace should not cover content on service queues page #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/esm-home-app/src/dashboard/home-dashboard.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function HomeDashboard() {
{isDesktop(layout) && <ExtensionSlot name="home-sidebar-slot" key={layout} />}
<DashboardView title={activeDashboard?.name} dashboardSlot={activeDashboard?.slot} />
</section>
<WorkspaceContainer overlay contextKey="home" />
<WorkspaceContainer contextKey="home" />
Copy link
Member

@vasharma05 vasharma05 Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will be made for all the workspaces shown on the /home path, which also includes Wards Workspaces and others.

Copy link
Author

@jwnasambu jwnasambu Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasharma05, You are right, and I raised the same question during the coffee break (10 Dec 2024) while we were debugging the issue. My suggestion then was to avoid affecting other workspaces by ensuring that each workspace has its own WorkspaceContainer component, with an overlay on top of the content to simplify styling without affecting other workspaces. The main essence of pushing this PR was to get members' views after implementing what @brandones had suggested on the ticket.

</div>
);
}
Loading