ATT-1: Enable rotation of image attachments, adding the javascript cod… #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you see the failing ci build tests? |
|
I did and i am trying to get my head around the code base to see how i
could write the test cases
…On Sun, Apr 28, 2019 at 4:05 PM HerbertYiga ***@***.***> wrote:
did you see the failing ci build tests?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHHQANYYLHCGEVNN2SYAOPLPSW4LTANCNFSM4HAETB7Q>
.
|
mks-d
changed the title
|
@Wandji69 this should probably be a draft PR while the ticket is still in design. This will require to modify the UI as well, so that the thumbnail 'edit mode' shows a rotation icon/button, only for attachments of the image family. |
added 2 commits
May 7, 2020 15:23
Merge branch 'master' of https://github.com/openmrs/openmrs-module-attachments into ATT-1
|
I have implemented the rotation of images and I have issues on the test part please can some help me look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e and enabling the java code to call 'rotate instruction
https://issues.openmrs.org/browse/ATT-1