-
Notifications
You must be signed in to change notification settings - Fork 53
feat: add config flag support for deploy, preview, and upload commands #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add config flag support for deploy, preview, and upload commands #762
Conversation
🦋 Changeset detectedLatest commit: 3ab5680 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the issue and PR @0ta-mjn @james-elicx can you please review? |
* @param args - CLI arguments. | ||
* @returns Value of the config flag. | ||
*/ | ||
export function getWranglerConfigFlag(args: string[]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should create a factory function taking the short and long names two factor code across those last 2 functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I had the same thought as well
I have a different implementation in #768 where we now retrieve the wrangler config earlier and pass it to the commands |
Thanks! The PR was merged. I guess the main change you'll need to do is to use https://github.com/opennextjs/opennextjs-cloudflare/pull/768/files#diff-bd8a4f60544321df03ee5dd39591e77190dd5df249b81ef9b49dfb0f3c941059R140 |
Sorry for the back and forth but please wait for #746 to be merged as well. |
Based on #761