Skip to content

Commit 4a5a2eb

Browse files
committed
chore: use netlify-cli as a regular dev dep
Instead of adding nondeterminism to our CI by installing netlify-cli@latest on each run, just install it as a regular dev dep and let Renovate handle bumps. In the case of the next.js repo e2e tests, reference this repo (which is guaranteed to be a sibling directory) to access the netlify-cli binary.
1 parent 850ee8a commit 4a5a2eb

File tree

5 files changed

+41693
-12525
lines changed

5 files changed

+41693
-12525
lines changed

.github/workflows/run-tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ jobs:
7272
env:
7373
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
7474
run: |
75-
# TODO(serhalp) Unpin version once
76-
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
77-
npm i -g netlify-cli@17.26.0
7875
netlify login
7976
- name: Get installed Playwright version
8077
id: playwright-version
@@ -208,9 +205,6 @@ jobs:
208205
env:
209206
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
210207
run: |
211-
# TODO(serhalp) Unpin version once
212-
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
213-
npm i -g netlify-cli@17.26.0
214208
netlify login
215209
- name: Resolve Next.js version
216210
id: resolve-next-version

.github/workflows/test-e2e.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,6 @@ jobs:
179179
run: npm run build
180180
working-directory: ${{ env.runtime-path }}
181181

182-
- name: add netlify cli
183-
run: npm install -g netlify-cli
184-
185182
- name: Install Playwright Browsers
186183
run: npx playwright install --with-deps
187184
working-directory: ${{ env.next-path }}

0 commit comments

Comments
 (0)