chore: actually typecheck deno files, fix errors

We weren't including Deno files in `tsc` typechecking, but we also weren't using any `deno` commands
that typecheck.

This introduces typechecking in CI and fixes resulting hidden errors.

The JSON hack isn't great but really it's the whole "import a json and write new data to it" pattern
that should be simplified to "just read the new data in memory", since there's no actual reason to
write it to disk if you follow the code paths. It was just done that way because it was the shortest
path to add the dynamic fissue annotation from the previous implementation.

Author: serhalp

.github/workflows/deno-test.yml

@@ -12,5 +12,9 @@ jobs:
         uses: denoland/setup-deno@v1
         with:
           deno-version: vx.x.x
+      - name: Typecheck
+        run: npm run typecheck:deno
+      - name: Lint
+        run: npm run lint:deno
       - name: Test
-        run: deno test -A edge-runtime/
+        run: npm run test:deno

.github/workflows/lint.yml

@@ -34,9 +34,9 @@ jobs:
       - name: Lint
         # github adds inline annotation for compact or stylish format
         # which is different than our default for local usage
-        run: npm run lint -- --format=compact
+        run: npm run lint:node -- --format=compact
       - name: Types
-        run: npm run typecheck
+        run: npm run typecheck:node
         # we still want to check types if lint fails just to know everything
         # and not peel errors to uncover new ones of different type
         if: always()

deno.json

@@ -0,0 +1,29 @@
+{
+  "exclude": [
+    "edge-runtime/vendor/",
+    "edge-runtime/shim/"
+  ],
+  "lint": {
+    "include": [
+      "tools/deno/",
+      "edge-runtime/"
+    ],
+    "exclude": [
+      // TODO(serhalp) Remove this exclusion and fix the lint errors here.
+      "edge-runtime/lib"
+    ]
+  },
+  "test": {
+    "include": [
+      "tools/deno/",
+      "edge-runtime/"
+    ]
+  },
+  "tasks": {
+    // TODO(serhalp) Add `edge-runtime/**/*.ts` and add a vendoring step in CI.
+    "typecheck": "deno check tools/deno/**/*.ts"
+  },
+  "imports": {
+    "@netlify/edge-functions": "https://edge.netlify.com/v1/index.ts"
+  }
+}

deno.jsonc

@@ -19,7 +19,9 @@
     "pretest:integration": "npm run build && node tests/prepare.mjs",
     "build": "node ./tools/build.js",
     "build:watch": "node ./tools/build.js --watch",
-    "lint": "eslint --cache --format=codeframe --max-warnings=0 --ext .ts,.cts,.js src",
+    "lint:node": "eslint --cache --format=codeframe --max-warnings=0 --ext .ts,.cts,.js src",
+    "lint:deno": "deno lint",
+    "lint": "npm run lint:node && npm run lint:deno",
     "format:fix": "prettier --write .",
     "format:check": "prettier --check .",
     "test": "vitest",
@@ -30,7 +32,10 @@
     "test:ci:unit-and-integration": "vitest run --reporter=default --retry=3 --project=unit --project=integration",
     "test:ci:smoke": "vitest run --reporter=default --retry=3 --project=smoke",
     "test:ci:e2e": "playwright test",
-    "typecheck": "tsc --noEmit"
+    "test:deno": "deno test -A",
+    "typecheck:node": "tsc --noEmit",
+    "typecheck:deno": "deno task typecheck",
+    "typecheck": "npm run typecheck:node && npm run typecheck:deno"
   },
   "repository": {
     "type": "git",

package.json

@@ -124,7 +124,9 @@
     {
       "file": "test/e2e/app-dir/app-static/app-static.test.ts",
       "reason": "Uses CLI output",
-      "tests": ["app-dir static/dynamic handling should warn for too many cache tags"]
+      "tests": [
+        "app-dir static/dynamic handling should warn for too many cache tags"
+      ]
     },
     {
       "file": "test/e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts",