test: adjust assertions to work with validateRSCRequestHeaders enabled #2985
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Jul 1, 2025
| if (response.url().includes('/test/rewrite-to-cached-page')) { | ||
| if ( | ||
| (response.url().includes('/test/rewrite-to-cached-page') || | ||
| response.url().includes('/caching-rewrite-target')) && |
There was a problem hiding this comment.
Note - the redirect that happens due to validateRSCRequestHeaders ( https://github.com/vercel/next.js/blob/21ff892d05e43644ebfd990d03d7f1742f9c46a7/packages/next/src/server/base-server.ts#L2086-L2098 ) result in seeing redirect with location being rewrite target
mrstork
approved these changes
Jul 2, 2025
pieh
deleted the
test-update-assertions-to-work-with-validateRSCRequestHeaders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next@canarynow are automatically opting intovalidateRSCRequestHeaders(note currently it seems like this is enabled in canary only - vercel/next.js#80954 so possibly won't be applied to future stable releases and will remain canary-only)This does result in additional 307 redirects for middleware redirects ... and rewrites (!).
In this PR I adjusted our currently failing tests for cache poisoning to work with that additional redirect