feature: use the actual ngx_connection_t * in ssl_client_hello_by#2416
Closed
climagabriel wants to merge 2 commits intoopenresty:masterfrom
Closed
feature: use the actual ngx_connection_t * in ssl_client_hello_by#2416climagabriel wants to merge 2 commits intoopenresty:masterfrom
climagabriel wants to merge 2 commits intoopenresty:masterfrom
Conversation
Do we really need to create a fake connection here? Sure, the request struct wasn't even created yet but the conneciton does exist. I personally need it because I need to allocate memory that will live for as long as the connection exists, not until the Lua chunk returns.
zhuizhuhaomeng
previously approved these changes
May 8, 2025
zhuizhuhaomeng
approved these changes
May 8, 2025
Contributor
Author
|
I read a bit more about openresty and realized that data persisting beyond the lifetime of a request goes against the design principles of the module so I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do we really need to create a fake connection here? Sure, the request struct wasn't even created yet but the conneciton does exist.
I personally need it because I need to allocate memory that will live for as long as the connection exists, not until the Lua chunk returns.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
Also, surely there must be a better way to do this.
c = ngx_ssl_get_connection(ssl_conn);
This line already does exist at the very top of ngx_http_lua_ssl_client_hello_handler().
If the real connection exists, can't we make it available in the Lua code itself?
The same way we make the fake request available by resty.core.base.get_request