Skip to content

Commit dcfbaf9

Browse files
authored
Reuse ExecutionContext with onError for Omniparser (#368)
To avoid swallowing throwables from parsers
1 parent b59913e commit dcfbaf9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

plugin/src/main/java/org/openrewrite/gradle/isolated/AndroidProjectParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ SourceFileStream parseProjectSourceSets(Project project,
172172
.collect(Collectors.toSet());
173173
sourceSetSourceFiles = Stream.concat(
174174
sourceSetSourceFiles,
175-
omniParser.parse(accepted, baseDir, new InMemoryExecutionContext())
175+
omniParser.parse(accepted, baseDir, ctx)
176176
.map(it -> it.withMarkers(it.getMarkers().add(javaVersion))));
177177
alreadyParsed.addAll(accepted);
178178
sourceSetSize += accepted.size();

plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ private SourceFileStream parseGradleProjectSourceSets(Project subproject,
881881
List<Path> accepted = omniParser.acceptedPaths(baseDir, resourcesDir.toPath());
882882
sourceSetSourceFiles = Stream.concat(
883883
sourceSetSourceFiles,
884-
omniParser.parse(accepted, baseDir, new InMemoryExecutionContext())
884+
omniParser.parse(accepted, baseDir, ctx)
885885
.map(it -> it.withMarkers(it.getMarkers().add(javaVersion))));
886886
alreadyParsed.addAll(accepted);
887887
sourceSetSize += accepted.size();

0 commit comments

Comments
 (0)