Fail hard on failure to resolve dependencies #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanman190
approved these changes
Sep 12, 2024
timtebeek
commented
Sep 12, 2024
| implementationClasspath = emptySet(); | ||
| throw new GradleException(String.format("Failed to resolve the dependencies from %s:%s; " + | ||
| "We can not reliably continue without this information.", | ||
| subproject.getPath(), implementationName), e); |
There was a problem hiding this comment.
As discussed internally we agreed in principle with throwing an exception; now need to replicate this to the other instances where we call resolve(); some of those hadn't yet done any exception handling, so need a bit of time to figure if throwing is even necessary there.
There was a problem hiding this comment.
So just a question, but is the default Gradle exception not sufficient when resolution fails? In this case, were creating a resolvable configuration where we may have had one that wasn't resolvable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fail hard on failure to resolve dependencies, as opposed to continuing with partial type information.
What's your motivation?
Partial type information can lead to missing changes, and hard to trouble shoot issues. We'd rather fail fast and hard, such that the underlying issues can be addressed.
Anything in particular you'd like reviewers to focus on?
Not too familiar with Gradle plugin development; throwing a GradleException seemed the best fit to achieve something similar to what we did in the Maven plugin.