Remove unused methods from AbstractRewriteTask
and RewriteClassLoader
#405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
We've had reports in #212 that parallel and partial runs throw an exception when trying to load duplicate classes.
Have you considered any alternatives or workarounds?
getOutputs().upToDateWhen(task -> false);
which we could set in AbstractRewriteTask instead.DelegatingProjectParser
to support parallel classloaders each with their ownGradleProjectParser
, but the impact of that on reliable recipe runs is hard to judge at this moment, but likely leads to fragile runs.org.openrewrite.gradle.RewriteClassLoader#loadClass
, but it's not clear whether that's a viable option here, and again could lead to fragile recipe runs.Any additional context
loader org.openrewrite.gradle.RewriteClassLoader attempted duplicate class definition
#212