Fix being unable to correctly load recipes whose superclasses come from other jars.#7338
Merged
Fix being unable to correctly load recipes whose superclasses come from other jars.#7338
Conversation
…s come from other jars. In the process, got rid of classgraph.
…t performance. Would all be better if we could cache the JDK types in a static field, but we've gone that route before unsuccessfully. Perhaps could load them from type tables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant when the recipe's superclass isn't
RecipeorScanningRecipeand is in a different jar from the recipe itself.Specifically came up in the context of Find and fix vulnerable dependencies.
In the process, got rid of classgraph. I had to work around it to get this working enough that I questioned if it was really doing anything worthwhile for us.
This uses substantially less memory during recipe loading.
It is slightly faster when loading recipes from a single jar with
scanJar. Whole-classpath scanning is slower but that is less relevant than ever.