Skip to content

Conversation

sepandhaghighi
Copy link
Member

@sepandhaghighi sepandhaghighi commented May 11, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • IPv4HTTPAdapter class added
  • _ipapi_ipv4 function modified
  • _ipinfo_ipv4 function modified

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2025

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (6a2cfb2) to head (f740ba3).

Files with missing lines Patch % Lines
ipspot/functions.py 88.09% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #28      +/-   ##
==========================================
+ Coverage   94.44%   94.59%   +0.15%     
==========================================
  Files           2        2              
  Lines         126      148      +22     
  Branches       14       15       +1     
==========================================
+ Hits          119      140      +21     
  Misses          1        1              
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi self-assigned this May 11, 2025
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label May 11, 2025
@sepandhaghighi sepandhaghighi added this to the ipspot v0.3 milestone May 11, 2025
@sepandhaghighi sepandhaghighi marked this pull request as ready for review May 11, 2025 22:28
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the two changed API _ipapi_ipv4 and _ipinfo_ipv4. They are working as expected returning ipv4s. However I checked them on the dev branch as well after that and I was getting ipv4 as well. If there's anything else I can test let me know.

I left a minor comment which is more educational for me rather than a deterrent for merging.

@sadrasabouri sadrasabouri merged commit 20d6b19 into dev May 12, 2025
22 checks passed
@sadrasabouri sadrasabouri deleted the adapter branch May 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants