-
-
Notifications
You must be signed in to change notification settings - Fork 4
IPv4 HTTP Adapter #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #28 +/- ##
==========================================
+ Coverage 94.44% 94.59% +0.15%
==========================================
Files 2 2
Lines 126 148 +22
Branches 14 15 +1
==========================================
+ Hits 119 140 +21
Misses 1 1
- Partials 6 7 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the two changed API _ipapi_ipv4
and _ipinfo_ipv4
. They are working as expected returning ipv4s. However I checked them on the dev
branch as well after that and I was getting ipv4 as well. If there's anything else I can test let me know.
I left a minor comment which is more educational for me rather than a deterrent for merging.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
IPv4HTTPAdapter
class added_ipapi_ipv4
function modified_ipinfo_ipv4
function modifiedAny other comments?